[asterisk-dev] [Code Review] Sets -rpath linker option when appropriate

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2132/#review7674
-----------------------------------------------------------

Ship it!


I'll go out on a limb and say Ship It!. No one has posed an objection on asterisk-dev and the patch looks correct.

- Matt


On Jan. 7, 2013, 3:57 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2132/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2013, 3:57 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Sets -rpath linker option when appropriate.
> 
>  * For OS's other than OS X, add the -rpath linker option if prefix is
>    anything other than /usr. This can be disabled by passing
>    --disable-rpath to ./configure.
>  * For OS X, we have macosx_version_min set to 10.4, which doesn't
>    support rpath. So instead, the patch adds the -dynamiclib and
>    -install_name flags for linking libasteriskssl.dylib, along with
>    cleaning up some of the other OS X specific linker flags.
> 
> 
> This addresses bug ASTERISK-20407.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20407
> 
> 
> Diffs
> -----
> 
>   /branches/11/Makefile 373907 
>   /branches/11/configure UNKNOWN 
>   /branches/11/configure.ac 373907 
>   /branches/11/main/Makefile 373907 
>   /branches/11/makeopts.in 373907 
> 
> Diff: https://reviewboard.asterisk.org/r/2132/diff
> 
> 
> Testing
> -------
> 
> Built on OS X and Ubuntu Precise, --prefix=/opt/Asterisk, both with and without --disable-rpath.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130117/0e6ed28b/attachment.htm>