[asterisk-dev] [Code Review]: Sorcery Data Access Abstraction Layer

[jcolp]

> On Jan. 3, 2013, 4:49 p.m., Matt Jordan wrote:
> > /trunk/include/asterisk/sorcery.h, line 28
> > <https://reviewboard.asterisk.org/r/2259/diff/2/?file=32528#file32528line28>
> >
> >     "utilizes" instead of "utilizies"

Fixed.


> On Jan. 3, 2013, 4:49 p.m., Matt Jordan wrote:
> > /trunk/include/asterisk/sorcery.h, lines 180-196
> > <https://reviewboard.asterisk.org/r/2259/diff/2/?file=32528#file32528line180>
> >
> >     Potentially, a wizard may want to make any of the four CRUD operations optional. For example, a read-only persistent storage would want to disable creation, updating, and deletion.
> >     
> >     It's possible that the sorcery core may want to handle that, and let callers know that no wizard existed for that object that could satisfy the request.

Made all operations optional, yay.


- jcolp


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2259/#review7599
-----------------------------------------------------------


On Jan. 3, 2013, 12:33 p.m., jcolp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2259/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2013, 12:33 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Sorcery is a new API which provides a generic data access/persistence mechanism. A user of this API defines their objects with some special sorcery specific contents. The object types themselves and the fields within the objects are then registered with sorcery. Operations can then occur to create, retrieve, update, or delete objects. There's also other aspects present such as configuration for mapping object types to different persistence mechanisms (with the current one available being in-memory). Other operations also exist which allow objects to be copied and diffed.
> 
> * I will run whitespace-cleanup on this :P red blobs will be gone.
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/sorcery.conf.sample PRE-CREATION 
>   /trunk/include/asterisk/sorcery.h PRE-CREATION 
>   /trunk/main/asterisk.c 378411 
>   /trunk/main/sorcery.c PRE-CREATION 
>   /trunk/res/res_sorcery_memory.c PRE-CREATION 
>   /trunk/tests/test_sorcery.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2259/diff
> 
> 
> Testing
> -------
> 
> Ran unit tests, confirmed they all passed and made changes to ensure the tests are valid.
> 
> 
> Thanks,
> 
> jcolp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130104/075cff58/attachment-0001.htm>