[asterisk-dev] [Code Review] Regex support for sorcery object fields

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2332/#review7955
-----------------------------------------------------------

Ship it!


The only thing I see is the one trivial item below.  Otherwise, this looks good to me.


/trunk/main/sorcery.c
<https://reviewboard.asterisk.org/r/2332/#comment15063>

    This should be ast_free() since its function pointer is not being passed as a parameter.


- opticron


On Feb. 16, 2013, 4:08 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2332/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2013, 4:08 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This change adds support to sorcery for specifying a regex for an object field name. This requires that a custom handler be provided for doing the translation from string to native type. Going from native type to strings is optional, but if implemented requires that a list of ast_variable structures be returned. This change also includes unit tests.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/sorcery.h 381627 
>   /trunk/main/sorcery.c 381627 
>   /trunk/tests/test_sorcery.c 381627 
> 
> Diff: https://reviewboard.asterisk.org/r/2332/diff
> 
> 
> Testing
> -------
> 
> Ran unit tests, confirmed happy.
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130228/1b074d38/attachment.htm>