[asterisk-dev] [Code Review] Don't undefine bzero/bcopy

Paul Belanger reviewboard at asterisk.org
Wed Feb 27 20:11:54 CST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2359/#review7952
-----------------------------------------------------------



/trunk/res/res_rtp_asterisk.c
<https://reviewboard.asterisk.org/r/2359/#comment15061>

    I lol'd


- Paul


On Feb. 27, 2013, 4:42 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2359/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2013, 4:42 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When building against external headers, we currently fail if they use bzero()/bcopy(), unless we resort to silliness in modules to get around the issue.  While these functions have been marked as legacy for 12 years, and have been removed from the POSIX spec for 5 years, there is still use of them in the wild.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk.h 382217 
>   /trunk/res/res_rtp_asterisk.c 382217 
> 
> Diff: https://reviewboard.asterisk.org/r/2359/diff
> 
> 
> Testing
> -------
> 
> Things build properly.
> 
> 
> Thanks,
> 
> Jason
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130228/7dd01ae9/attachment.htm>


More information about the asterisk-dev mailing list