[asterisk-dev] [Code Review] Consider linux-gnuspe as linux-gnu

[Tzafrir Cohen]

Review-board is down, taking this to the list,

On Tue, Feb 26, 2013 at 08:00:45AM -0000, wdoekes wrote:
> Tzafrir Cohen wrote:
> > The powerpcspe Linux port uses linux-gnuspe as the OS string.
> > 
> > Our build system shouldn't really care for that, so just call it linux-gnu.
> > 
> > Original report: Roland Stigge , http://bugs.debian.org/701505
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2357/#review7944
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> Sounds sane to me.
> 
> 
> Although. The * wildcard was just added to cater for `linux-gnueabihf`.
> 
> ------------------------------------------------------------------------
> r380522 | mjordan | 2013-01-30 18:49:38 +0100 (Wed, 30 Jan 2013) | 21 lines
> 
> Support building Asterisk for Raspberry Pi/Raspbian with hard-float support
> ------------------------------------------------------------------------

That's interesting. Raspbian is essentially the same as the Debian armhf
port. I have added support for that quite a while ago. Why was the above
needed?

That "support" was added in r327413:

  r327411 | tzafrir | 2011-07-11 13:46:34 +0300 (ב', 11 יול 2011) | 5 lines

  fix building the Debian armhf (HardFloat) port

  Fixes http://buildd.debian-ports.org/status/fetch.php?pkg=asterisk&arch=ar
  (Missing pthreads)

Its change:

--- a/main/Makefile
+++ b/main/Makefile
@@ -35,7 +35,7 @@ AST_LIBS += $(BKTR_LIB)
 AST_LIBS += $(LIBXML2_LIB)
 AST_LIBS += $(SQLITE3_LIB)

-ifneq ($(findstring $(OSARCH), linux-gnu uclinux linux-uclibc linux-gnueabi kfreebsd-gnu),)
+ifneq ($(findstring $(OSARCH), linux-gnu uclinux linux-uclibc linux-gnueabi kfreebsd-gnu linux-gnueabihf),)
   ifneq ($(findstring LOADABLE_MODULES,$(MENUSELECT_CFLAGS)),)
   AST_LIBS+=-ldl
   endif

> 
> I wonder if we're not back here in a month with `linux-gnulp` or `linux-gnuspehf` or <fill in the blanks>.
> 
> Shouldn't we use linux-gnu* instead?

linux-gnueabi and linu-gnueabihf can now be removed from that line. What
about linux-uclibc?

Is OSARCH used in anything excet simple Makefile choices?

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen at xorcom.com
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir