[asterisk-dev] [Code Review] Disallow MoH upon hold option

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2336/#review7943
-----------------------------------------------------------

Ship it!


Looks good by me. Just address Josh's comment.

- Mark


On Feb. 19, 2013, 3:26 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2336/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2013, 3:26 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> A remote hold via SIP causes local music on hold.  Added a per peer option "discard_remote_hold_retrieval" (default "no") that if set will not trigger the music on hold event.
> 
> 
> This addresses bug ABE-2899.
>     https://issues.asterisk.org/jira/browse/ABE-2899
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 381793 
>   /trunk/channels/chan_sip.c 381793 
>   /trunk/channels/sip/include/sip.h 381793 
> 
> Diff: https://reviewboard.asterisk.org/r/2336/diff
> 
> 
> Testing
> -------
> 
> Set the discard_remote_hold_retrieval option for phone A, called phone B, and then had phone A place phone B on hold.  No music on hold was played.  Also wrote a test for the teststuite that runs through several scenarios and makes sure that no music on hold event is raised.
> 
> 
> Thanks,
> 
> Kevin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130225/09ee1c5a/attachment.htm>