[asterisk-dev] [Code Review] Option for Read to be able to accept #

[Sean Bright]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2354/#review7936
-----------------------------------------------------------


Just a few things I noticed - didn't do a thorough review.


http://svn.asterisk.org/svn/asterisk/trunk/apps/app_read.c
<https://reviewboard.asterisk.org/r/2354/#comment15044>

    Drop the '!'



http://svn.asterisk.org/svn/asterisk/trunk/apps/app_read.c
<https://reviewboard.asterisk.org/r/2354/#comment15045>

    New code should use braces for blocks.


- Sean


On Feb. 23, 2013, 9:11 a.m., Birger Harzenetter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2354/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2013, 9:11 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Option for Read to be able to accept #
> https://issues.asterisk.org/jira/browse/ASTERISK-18454
> 
> 
> This addresses bug ASTERISK-18454.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18454
> 
> 
> Diffs
> -----
> 
>   http://svn.asterisk.org/svn/asterisk/trunk/apps/app_read.c 381515 
> 
> Diff: https://reviewboard.asterisk.org/r/2354/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Birger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130225/3788e63b/attachment.htm>