[asterisk-dev] [Code Review] Add Path header support to chan_sip

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2235/#review7921
-----------------------------------------------------------


I did a manual test with a realtime peer and the Path field was properly updated.

I am curious if we really need rtsavepath. If a peer has supportpath and is a realtime peer, is there any reason why we wouldn't automatically save the path information to the peer's entry in the database?

- Matt


On Dec. 7, 2012, 5:01 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2235/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2012, 5:01 a.m.)
> 
> 
> Review request for Asterisk Developers and Klaus Darilion.
> 
> 
> Summary
> -------
> 
> This is continued development based on https://reviewboard.asterisk.org/r/991/ by Klaus Darillion
> 
> In that review Klaus wrote:
> "This patch adds support for the Parse header (RFC 3327). This allows to record the Path (route) of incoming REGISTER requests and then reuse the learned path on outgoing out-of-dialog requests as a pre-loaded route set.
> 
> I tried to reuse as much of existing code as possible. There are several parts where I am not sure if it is implemented nice and follow chan_sip design rules (are there any?) I will post my questions as a review to myself."
> 
> ---
> I have added realtime support and the global flags, as well as some other minor fixes. The bulk of this code is still Klaus' work.
> 
> 
> This addresses bug ASTERISK-16884.
>     https://issues.asterisk.org/jira/browse/ASTERISK-16884
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/sip/include/sip.h 377373 
>   /trunk/configs/sip.conf.sample 377373 
>   /trunk/channels/chan_sip.c 377373 
>   /trunk/contrib/realtime/mysql/sippeers.sql 377373 
>   /trunk/contrib/realtime/postgresql/realtime.sql 377373 
> 
> Diff: https://reviewboard.asterisk.org/r/2235/diff
> 
> 
> Testing
> -------
> 
> I have this patch running with and without NAT, but not with realtime. Will test, but have also asked for testers on asterisk-dev. Need help with the LDAP schemas.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130223/aca9c8d6/attachment.htm>