[asterisk-dev] [Code Review] bridging: Holding bridge technology and app_bridgewait

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2342/
-----------------------------------------------------------

(Updated Feb. 22, 2013, 3:11 p.m.)


Review request for Asterisk Developers and rmudgett.


Changes
-------

Updated to address concerns and fix that I left out the threading capability.  Oops.  Also some docs.


Summary
-------

This fulfills some of the preliminary goals needed for refactoring parking. First I've created a bridging technology that is very minimalistic in nature (it doesn't do any actual communication between channels on a given holding bridge) for storing parked calls. This technology will also likely be used for queues and maybe some other stuff later on. Second, I've created an application that holds a reference to a single holding bridge which can place channels into the holding bridge.  It includes some options for playing music on hold, ringing, and for breaking the bridge (such as in a queue/park timeout) after a certain amount of time.

I haven't implemented any kind of silence generation since I'm not sure it would be necessary and I'm also just plain not sure how to do that at the moment.


This addresses bug ASTERISK-21059.
    https://issues.asterisk.org/jira/browse/ASTERISK-21059


Diffs (updated)
-----

  /team/jrose/bridge_projects/apps/app_bridgewait.c PRE-CREATION 
  /team/jrose/bridge_projects/bridges/bridge_holding.c PRE-CREATION 
  /team/jrose/bridge_projects/include/asterisk/bridging.h 381895 

Diff: https://reviewboard.asterisk.org/r/2342/diff


Testing
-------

So far I've just been testing the app against the options and seeing how the channels work in bridges. Everything seems to work as expected.

exten => 40,1,Answer()
exten => 40,n,BridgeWait(mS(8))
exten => 40,n,Playback(tt-weasels)

exten => 41,1,Answer()
exten => 41,n,BridgeWait(rS(10))
exten => 41,n,Playback(queue-youarenext)

exten => 42,1,Answer()
exten => 42,n,BridgeWait()


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130222/55b1d3ec/attachment.htm>