[asterisk-dev] [Code Review] RPID not parsed correctly if display-name is *(token LWS)

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2341/
-----------------------------------------------------------

(Updated Feb. 22, 2013, 1:15 a.m.)


Review request for Asterisk Developers.


Changes
-------

Fixed typo found by Kinsey.


Summary
-------

get_rpid() only allows the quoted-string style display-name.

Remote-Party-ID    = "Remote-Party-ID" HCOLON rpid *(COMMA rpid)
rpid               =  [display-name] LAQUOT addr-spec RAQUOT *(SEMI rpi-token)
display-name       =  *(token LWS)/ quoted-string

This patch allows *(token LWS) too. (And one without trailing LWS.)


I could've used the reqresp_parser functions, but I didn't want to change around too much in the 1.8 branch.


This addresses bug ASTERISK-21141.
    https://issues.asterisk.org/jira/browse/ASTERISK-21141


Diffs (updated)
-----

  /branches/1.8/channels/chan_sip.c 381817 

Diff: https://reviewboard.asterisk.org/r/2341/diff


Testing
-------

Yes.

Both
  Remote-Party-ID: abc <sip:123 at def>;... => "abc"
and
  Remote-Party-ID: "abc" <sip:123 at def>;... => "abc"
work.

As do:
  Remote-Party-ID: abc <sip:123 at def>;... => "abc"
  Remote-Party-ID: abc def <sip:123 at def>;... => "abc def"
  Remote-Party-ID: abc def<sip:123 at def>;... => "abc def"


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130222/a54fe717/attachment.htm>