[asterisk-dev] [Code Review] Add tests for Path header support

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2325/#review7877
-----------------------------------------------------------



/asterisk/trunk/tests/channels/SIP/path/sipp/registrar.xml
<https://reviewboard.asterisk.org/r/2325/#comment14955>

    I don't think this belongs in a reply to a REGISTER.


- opticron


On Feb. 13, 2013, 6:35 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2325/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 6:35 a.m.)
> 
> 
> Review request for Asterisk Developers, Olle E Johansson and Klaus Darilion.
> 
> 
> Summary
> -------
> 
> This patch adds a test to the Asterisk Test Suite to support the Path header extension in https://reviewboard.asterisk.org/r/2235/. The tests covers two scenarios:
> 
> 1. A UA sends a REGISTER request to Asterisk. The test verifies that the Path header in the request is copied into the 200 OK response and that the response indicates support for 'path'. It then verifies that a subsequent request sent to the UA (An INVITE for a new call) contains the path information in the Route header.
> 
> 2. If path support is enabled globally, it verifies that outbound REGISTER requests from Asterisk indicate support for 'path'.
> 
> 
> This addresses bug ASTERISK-16884.
>     https://issues.asterisk.org/jira/browse/ASTERISK-16884
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/path/sipp/registrar.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/path/sipp/ua1_invite_recv.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/path/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/path/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/path/sipp/ua1_register.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/path/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/tests.yaml 3635 
> 
> Diff: https://reviewboard.asterisk.org/r/2325/diff
> 
> 
> Testing
> -------
> 
> Tests were set up in Bamboo to run on Olle's branch. Note that prior test runs were expected to fail, as the branch didn't yet send the Path header in the REGISTER response, which the test checks for.
> 
> A successful test run *should* be http://bamboo.asterisk.org/browse/ASTTEAM-OOLONGPATHSUPPORTTRUNK-12/ (when its done running, anyway)
> 
> 
> Thanks,
> 
> Matt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130214/a8b75ab3/attachment.htm>