[asterisk-dev] [Code Review] Add serviceURL stuff to skinny

opticron reviewboard at asterisk.org
Thu Feb 14 14:17:35 CST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2321/#review7867
-----------------------------------------------------------



/trunk/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2321/#comment14938>

    Blob.



/trunk/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2321/#comment14948>

    This will segfault if there is no comma in the string provided.


- opticron


On Feb. 7, 2013, 2:43 p.m., wedhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2321/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2013, 2:43 p.m.)
> 
> 
> Review request for Asterisk Developers and Brad Latus.
> 
> 
> Summary
> -------
> 
> Patch adds all the packet and structure stuff to skinny to enable setting service URLs in skinny, such as corporate directories.
> 
> This stuff is only relevant during load/unload as when activated. Also some minor changes removing duplicated counting of addons and speedials in handle_skinny_show_devices.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_skinny.c 380943 
>   /trunk/configs/skinny.conf.sample 380943 
> 
> Diff: https://reviewboard.asterisk.org/r/2321/diff
> 
> 
> Testing
> -------
> 
> Tested on v6 7960 and v17 7961. Works.
> 
> 
> Thanks,
> 
> wedhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130214/f040a4d1/attachment.htm>


More information about the asterisk-dev mailing list