[asterisk-dev] [Code Review]: Add Path header support to chan_sip

[Matt Jordan]

> On Dec. 31, 2012, 9:38 a.m., Matt Jordan wrote:
> > When this goes in, it'd be nice if we had some automated tests that covered proper storage/sending of Path headers. Some sample SIP message traffic as a pcap should suffice in getting that taken care of - that could be easily converted into a SIPp scenario.
> 
> Matt Jordan wrote:
>     See https://reviewboard.asterisk.org/r/2325
> 
> Olle E Johansson wrote:
>     Matt says Thank You to Matt. :-)
>     
>     The code in my subversion is ahead of this review. I added Route header support for OPTIONs messages too.
> 
> Olle E Johansson wrote:
>     Do we have anything to test realtime in the test framework?
>     
>     Olle says thank you for the tests too :-)

Awesome! I saw that you had that finding on the Jira issue - glad you already fixed it.

We have a few very basic realtime tests, but the realtime coverage in the Test Suite is honestly lacking a bit. In practice, we've found that getting the Test Suite to run reliably when databases are involved has been challenging - it's certainly doable, but requires a bit of infrastructure support that we haven't added to it yet. The few realtime tests that exist are functional, but I'd be hesitant to try and put together a test that covers dynamic realtime updating of a table.

I'll try to do a manual test of that however.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2235/#review7586
-----------------------------------------------------------


On Dec. 7, 2012, 5:01 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2235/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2012, 5:01 a.m.)
> 
> 
> Review request for Asterisk Developers and Klaus Darilion.
> 
> 
> Summary
> -------
> 
> This is continued development based on https://reviewboard.asterisk.org/r/991/ by Klaus Darillion
> 
> In that review Klaus wrote:
> "This patch adds support for the Parse header (RFC 3327). This allows to record the Path (route) of incoming REGISTER requests and then reuse the learned path on outgoing out-of-dialog requests as a pre-loaded route set.
> 
> I tried to reuse as much of existing code as possible. There are several parts where I am not sure if it is implemented nice and follow chan_sip design rules (are there any?) I will post my questions as a review to myself."
> 
> ---
> I have added realtime support and the global flags, as well as some other minor fixes. The bulk of this code is still Klaus' work.
> 
> 
> This addresses bug ASTERISK-16884.
>     https://issues.asterisk.org/jira/browse/ASTERISK-16884
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/sip/include/sip.h 377373 
>   /trunk/configs/sip.conf.sample 377373 
>   /trunk/channels/chan_sip.c 377373 
>   /trunk/contrib/realtime/mysql/sippeers.sql 377373 
>   /trunk/contrib/realtime/postgresql/realtime.sql 377373 
> 
> Diff: https://reviewboard.asterisk.org/r/2235/diff
> 
> 
> Testing
> -------
> 
> I have this patch running with and without NAT, but not with realtime. Will test, but have also asked for testers on asterisk-dev. Need help with the LDAP schemas.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130213/5549914d/attachment.htm>