[asterisk-dev] [Code Review] Add a serializer interface to the threadpool

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2323/#review7843
-----------------------------------------------------------

Ship it!


Aside from the discrepancy in the serializer_dupe test, this looks good to go.


/trunk/tests/test_threadpool.c
<https://reviewboard.asterisk.org/r/2323/#comment14880>

    Your new change results in two different threadpool serializer names. This test should have failed.


- Mark


On Feb. 11, 2013, 2:22 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2323/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2013, 2:22 p.m.)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Summary
> -------
> 
> This patch adds the ability to create a serializer from a thread pool. A
> serializer is a ast_taskprocessor with the same contract as a default
> taskprocessor (tasks execute serially) except instead of executing out
> of a dedicated thread, execution occurs in a thread from a
> ast_threadpool. Think of it as a lightweight thread.
> 
> While it guarantees that each task will complete before executing the
> next, there is no guarantee as to which thread from the pool individual
> tasks will execute. This normally only matters if your code relys on
> thread specific information, such as thread locals.
> 
> This patch also fixes a bug in how the 'was_empty' parameter is computed
> for the push callback.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/threadpool.h 381085 
>   /trunk/main/taskprocessor.c 381085 
>   /trunk/main/threadpool.c 381085 
>   /trunk/tests/test_taskprocessor.c 381085 
>   /trunk/tests/test_threadpool.c 381085 
> 
> Diff: https://reviewboard.asterisk.org/r/2323/diff
> 
> 
> Testing
> -------
> 
> Unit testing.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130211/4b057bc2/attachment-0001.htm>