[asterisk-dev] [Code Review] Stopped spamming of debug messages during attended transfer

Kevin Harwell reviewboard at asterisk.org
Fri Feb 8 16:21:04 CST 2013

This is an automatically generated e-mail. To reply, visit:

Review request for Asterisk Developers, jrose and Matt Jordan.


While autoservice is running and servicing a channel the callid is being stored and removed in the thread's local storage for each iteration of the thread loop.  If debug was set to a sufficient level the log file would be spammed with callid thread local storage debug messages.  Added a new function that checks to see if the callid to be stored is different than what is already contained (if anything).  If it is different then store/replace and log, otherwise just leave as is.

This addresses bug ASTERISK-21014.


  /trunk/include/asterisk/logger.h 379127 
  /trunk/main/autoservice.c 379127 
  /trunk/main/logger.c 379127 

Diff: https://reviewboard.asterisk.org/r/2324/diff


Reproduced the problem as per the issue, and then tested to make sure the problem no longer existed.  Also tested multiple calls/transfers from two phones at roughly the same time.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130208/947d7f6d/attachment-0001.htm>

More information about the asterisk-dev mailing list