[asterisk-dev] [Code Review]: Add variable length displayprompt packet to skinny and use octals

[wedhorn]

> On Feb. 1, 2013, 4:33 p.m., opticron wrote:
> > /trunk/channels/chan_skinny.c, line 2886
> > <https://reviewboard.asterisk.org/r/2294/diff/4/?file=33258#file33258line2886>
> >
> >     Does SCCP/the phone require a trailing null terminator on this string?  If it does, the length calculation here does not account for it.

I'm not sure, didn't test without a terminating null. But at least one null (up to 4) will be included at the end of the packet by the operation of line 2760.


- wedhorn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2294/#review7794
-----------------------------------------------------------


On Feb. 1, 2013, 4:11 p.m., wedhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2294/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2013, 4:11 p.m.)
> 
> 
> Review request for Asterisk Developers and Brad Latus.
> 
> 
> Summary
> -------
> 
> Add new variable length displayprompt packet (0x0145) to skinny. This uses a similar method to the variable length callinfo packet in https://reviewboard.asterisk.org/r/2290/. Uses the new packet if the device is reporting protocol versions >= 17.
> 
> Add the use of octal codes for sending prompts to both the new and old displayprompt messages (also cleaned up soft_key_template_default to use the defined octal codes).
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_skinny.c 380755 
> 
> Diff: https://reviewboard.asterisk.org/r/2294/diff
> 
> 
> Testing
> -------
> 
> Several calls on devices with protocol versions of 6 and 17. Prompts as expected.
> 
> 
> Thanks,
> 
> wedhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130201/110d9a60/attachment.htm>