[asterisk-dev] [Code Review] Add variable length displayprompt packet to skinny and use octals

[wedhorn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2294/
-----------------------------------------------------------

(Updated Feb. 1, 2013, 3:21 p.m.)


Review request for Asterisk Developers and Brad Latus.


Changes
-------

Revised silly use of sizeof ptr, now using strlen. Other changes to fix consequent bugs of being fed the correct, but smaller, octalstrlen. 


Summary
-------

Add new variable length displayprompt packet (0x0145) to skinny. This uses a similar method to the variable length callinfo packet in https://reviewboard.asterisk.org/r/2290/. Uses the new packet if the device is reporting protocol versions >= 17.

Add the use of octal codes for sending prompts to both the new and old displayprompt messages (also cleaned up soft_key_template_default to use the defined octal codes).


Diffs (updated)
-----

  /trunk/channels/chan_skinny.c 380755 

Diff: https://reviewboard.asterisk.org/r/2294/diff


Testing
-------

Several calls on devices with protocol versions of 6 and 17. Prompts as expected.


Thanks,

wedhorn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130201/1328147a/attachment.htm>