[asterisk-dev] [Code Review] 3088: ari: Remove support for specifying channel vars during origination.

[David Lee]

> On Dec. 20, 2013, 3:51 p.m., Matt Jordan wrote:
> > /branches/12/res/ari/resource_applications.h, line 91
> > <https://reviewboard.asterisk.org/r/3088/diff/1/?file=49930#file49930line91>
> >
> >     Undo this - the comment is now correct in the code (deviceState)

Actually, that's in the generated code.

I fixed the doc in rest-api/api-docs/applications.json.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3088/#review10486
-----------------------------------------------------------


On Dec. 20, 2013, 3:50 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3088/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2013, 3:50 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Bugs: ASTERISK-23051
>     https://issues.asterisk.org/jira/browse/ASTERISK-23051
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When we added support for specifying channel variables for an
> origination, we didn't consider how that would interact with another
> feature, namely specifying request parameters in a JSON request body.
> 
> The method of specifying channel variables (as a flat JSON object passed
> in the JSON body) interferes with parsing parameters out of the request
> body.
> 
> Unfortunately, fixing this would be a backward incompatible change. In
> the interest of keeping the API sane and keeping our release schedule,
> we're dropping the feature for specifying channel variables in the
> origination request.
> 
> We will bring the feature back soon, as a backward compatible addition
> to the API.
> 
> 
> Diffs
> -----
> 
>   /branches/12/rest-api/api-docs/channels.json 404507 
>   /branches/12/res/res_ari_channels.c 404507 
>   /branches/12/res/ari/resource_channels.c 404507 
>   /branches/12/res/ari/resource_channels.h 404507 
>   /branches/12/res/ari/resource_applications.h 404507 
> 
> Diff: https://reviewboard.asterisk.org/r/3088/diff/
> 
> 
> Testing
> -------
> 
> In process.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131220/e3192599/attachment-0001.html>