[asterisk-dev] [Code Review] 3087: Mini-audit of the ao2_iterator loops in the new code files.

rmudgett reviewboard at asterisk.org
Fri Dec 20 14:07:08 CST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3087/
-----------------------------------------------------------

(Updated Dec. 20, 2013, 8:07 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

* Fixed several places where ao2_iterator_destroy() was not called.

* Fixed several iterator loop object variable reference problems.

* Fixed res_parking AMI actions returning non-zero.  Only the AMI logoff action can return non-zero.


Diffs
-----

  /branches/12/tests/test_stasis.c 404420 
  /branches/12/tests/test_scoped_lock.c 404420 
  /branches/12/tests/test_cel.c 404420 
  /branches/12/res/res_pjsip/location.c 404420 
  /branches/12/res/parking/parking_manager.c 404420 
  /branches/12/res/ari/resource_endpoints.c 404420 
  /branches/12/res/ari/resource_channels.c 404420 
  /branches/12/res/ari/resource_bridges.c 404420 

Diff: https://reviewboard.asterisk.org/r/3087/diff/


Testing
-------

Compiler only.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131220/779d9fc0/attachment-0001.html>


More information about the asterisk-dev mailing list