[asterisk-dev] [Code Review] 3043: pjsip: CLI commands

[rnewton]

> On Dec. 20, 2013, 7:35 p.m., rnewton wrote:
> > For "pjsip show endpoints", a formatting issue:
> > 
> >  <Endpoint/CID................................................>  <State.....>  <Channels.>
> >     I/OAuth:  <AuthId/UserName...........................................................>
> >         Aor:  <Aor............................................>  <MaxContact>
> >       Contact:  <Aor/ContactUri...............................>  <Status....>  <RTT(ms)..>
> >    Identify:  <MatchList.................................................................>
> >     Channel:  <ChannelId......................................>  <State.....>  <Time(sec)>
> >         Codec:  <Codec>  Exten: <DialedExten...........>  CLCID: <ConnectedLineCID.......>
> >  =========================================================================================
> > 
> >  6001                                                            In use        1 of inf
> >      InAuth:  6001/6001
> >         Aor:  6001                                               2
> >       Contact:  6001/sip:6001 at 10.24.18.16:5060;ob                Avail               3.739
> >     Channel: PJSIP/6001-00000000/Dial Up                    497
> >         Codec:  (ulaw)   Exten: 6002                      CLCID: "" <>
> > 
> > 
> > For the "Channel:" line, the "State" and "Time(sec)" values are out of their columns and the State is pushed up against the Channel ID to it's left.
> 
> rnewton wrote:
>     This alignment issue also appears to apply to "pjsip show channels"

and "pjsip list channels"


- rnewton


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3043/#review10479
-----------------------------------------------------------


On Dec. 20, 2013, 4:24 a.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3043/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2013, 4:24 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22610
>     https://issues.asterisk.org/jira/browse/ASTERISK-22610
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Implements the following cli commands:
> pjsip list aors
> pjsip list auths
> pjsip list channels
> pjsip list contacts
> pjsip list endpoints
> pjsip show aor(s)
> pjsip show auth(s)
> pjsip show channels
> pjsip show endpoint(s)
> 
> Also...
> Minor modifications made to the AMI command implementations to facilitate reuse.
> New function ast_variable_list_sort added to config.c and config.h to implement variable list sorting.
> New api ast_sip_for_each_identify added to module res_pjsip_endpoint_identifier_ip. Required new files res_pjsip_endpoint_identifier_ip.h and res_pjsip_endpoint_identifier_ip.exports.in.
> 
> Implementation of the summary statistics is still pending.
> I'm sure there will be lots of feedback here. :)
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip_registrar.c 404396 
>   branches/12/res/res_pjsip_endpoint_identifier_ip.exports.in PRE-CREATION 
>   branches/12/res/res_pjsip_endpoint_identifier_ip.c 404396 
>   branches/12/res/res_pjsip/pjsip_configuration.c 404396 
>   branches/12/res/res_pjsip/pjsip_cli.c PRE-CREATION 
>   branches/12/res/res_pjsip/location.c 404396 
>   branches/12/res/res_pjsip/include/res_pjsip_private.h 404396 
>   branches/12/res/res_pjsip/config_auth.c 404396 
>   branches/12/main/sorcery.c 404396 
>   branches/12/main/config.c 404396 
>   branches/12/include/asterisk/sorcery.h 404396 
>   branches/12/include/asterisk/res_pjsip_endpoint_identifier_ip.h PRE-CREATION 
>   branches/12/include/asterisk/res_pjsip_cli.h PRE-CREATION 
>   branches/12/include/asterisk/res_pjsip.h 404396 
>   branches/12/include/asterisk/config.h 404396 
> 
> Diff: https://reviewboard.asterisk.org/r/3043/diff/
> 
> 
> Testing
> -------
> 
> I've gone through all the combinations of actions and objects and made sure at least the correct objects are returned, there are no segfaults, errors, etc.
> I *think* the formatting is correct but I'll need some feedback.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131220/dc936daf/attachment.html>