[asterisk-dev] [Code Review] 3078: astdb: crash in sqlite3 during shutdown

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3078/
-----------------------------------------------------------

(Updated Dec. 18, 2013, 3:26 p.m.)


Review request for Asterisk Developers.


Changes
-------

statement is now null'd even on error 


Bugs: AST-1265 and ASTERISK-22350
    https://issues.asterisk.org/jira/browse/AST-1265
    https://issues.asterisk.org/jira/browse/ASTERISK-22350


Repository: Asterisk


Description
-------

When Asterisk is shut down, the astdb_atexit() function releases (finalizes) the previously initialized (prepared) SQL statements in sqlite3.  Another thread subsequently attempting an astdb operation tries to use the released statement and causes a violation in sqlite3.  This patch eliminates that issue by resetting the statement pointer after it is released/cleared.  Code in sqlite3 will detect the null pointer and abort the operation rather than crash.


Diffs (updated)
-----

  /branches/11/main/db.c 404197 

Diff: https://reviewboard.asterisk.org/r/3078/diff/


Testing
-------


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131218/39acab5d/attachment-0001.html>