[asterisk-dev] [Code Review] 3074: Fix old regression where config.c unescapes semicolons in embedded values in extensions.conf.

[George Joseph]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3074/
-----------------------------------------------------------

(Updated Dec. 17, 2013, 3:19 p.m.)


Status
------

This change has been discarded.


Review request for Asterisk Developers.


Bugs: 20127
    https://issues.asterisk.org/jira/browse/20127


Repository: Asterisk


Description
-------

This is one I've been patching locally since the middle of last year.   If you retrieve extensions.conf via ami and write it back again (as the Asterisk GUI does), config.c will UNescape semicolons in values causing the rest of the line to be considered a comment.

Lines such as 
PAGING_HEADER = Call-Info: \;answer-after=0
are being rewritten as 
PAGING_HEADER = Call-Info: ;answer-after=0

'answer-after=0' is now considered a comment and PAGING_HEADER is now just 'Call-Info:'.  Since the change to extensions.conf is permanent, this is really a data corruption.

This is a regression casued by v354657 of config.c.


Diffs
-----

  branches/12/main/config.c 403992 

Diff: https://reviewboard.asterisk.org/r/3074/diff/


Testing
-------

This patch has been in my production systems since July 2012.  


Thanks,

George Joseph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131217/3783d764/attachment.html>