[asterisk-dev] [Code Review] 3066: bridge_native_rtp: Deadlock during 4-way conference creation
opticron
reviewboard at asterisk.org
Thu Dec 12 15:16:27 CST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3066/#review10407
-----------------------------------------------------------
Ship it!
Looks good other than the documentation tweak below.
branches/12/bridges/bridge_native_rtp.c
<https://reviewboard.asterisk.org/r/3066/#comment19834>
These functions are not being called...
- opticron
On Dec. 12, 2013, 3:03 p.m., Kevin Harwell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3066/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2013, 3:03 p.m.)
>
>
> Review request for Asterisk Developers and kmoore.
>
>
> Bugs: ASTERISK-22749
> https://issues.asterisk.org/jira/browse/ASTERISK-22749
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> This contains the patch on the issue (submitted by kmoore), as well as the fix for the adding in a bridge lock while calling bridge_start from the framehook callback. Since the framehook callback is not called from the bridging core the bridge is not locked, but needs to be before calling bridge_start. The addition to the given patch adds in the necessary bridge locking in order to avoid a deadlock.
>
>
> Diffs
> -----
>
> branches/12/main/channel.c 403715
> branches/12/include/asterisk/channel.h 403715
> branches/12/channels/chan_sip.c 403715
> branches/12/channels/chan_pjsip.c 403715
> branches/12/bridges/bridge_native_rtp.c 403715
>
> Diff: https://reviewboard.asterisk.org/r/3066/diff/
>
>
> Testing
> -------
>
> Added channels via DTMF attended transfer to get to a 4-way bridge and then removed them and noted all channels and the bridge had been torn down.
>
>
> Thanks,
>
> Kevin Harwell
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131212/b47bdf9b/attachment.html>
More information about the asterisk-dev
mailing list