[asterisk-dev] [Code Review] 3063: chan_dahdi: enable ignore_failed_channels by default

rmudgett reviewboard at asterisk.org
Tue Dec 10 11:14:38 CST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3063/#review10359
-----------------------------------------------------------


I don't think changing this default is a good idea.  Enabling it is only useful if you are using the relative channel format.  I have yet to see anyone on the Asterisk users list actually use this format.

- rmudgett


On Dec. 10, 2013, 4:25 p.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3063/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2013, 4:25 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> If ignore_failed_channels is set to "true" for a channel, the channel will continue to be configured even if configuring it has failed.
> 
> One important this This allows Asterisk to start before all the DAHDI initialization is done and thus not force the starting order dahdi -> asterisk.
> 
> This patch changes the default of the feature from disabled to enabled.
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/chan_dahdi.conf.sample 403615 
>   /trunk/channels/chan_dahdi.c 403615 
> 
> Diff: https://reviewboard.asterisk.org/r/3063/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tzafrir Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131210/2fbe0a42/attachment-0001.html>


More information about the asterisk-dev mailing list