[asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

[Matt Jordan]

> On Dec. 10, 2013, 2:37 p.m., Joshua Colp wrote:
> > /branches/12/apps/app_cdr.c, line 187
> > <https://reviewboard.asterisk.org/r/3057/diff/1/?file=49203#file49203line187>
> >
> >     I think using a message router here is overkill. You already do a check in your callback for whether it is an appcdr message type or not, why not just stasis_subscribe with your callback and then unsubscribe/join on it?
> >     
> >     Same comment applies for your further impls.

I'm down with that.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3057/#review10352
-----------------------------------------------------------


On Dec. 10, 2013, 4:48 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3057/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2013, 4:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22884 and ASTERISK-22886
>     https://issues.asterisk.org/jira/browse/ASTERISK-22884
>     https://issues.asterisk.org/jira/browse/ASTERISK-22886
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When doing the rework of the CDR engine that pushed all of the logic into cdr.c and made it respond to changes in channel state over Stasis, I knew that accessing the CDR engine from the dialplan would be "slightly" non-deterministic. Dialplan threads would be accessing CDRs while Stasis threads would be updating the state of said CDRs - whereas in the past, everything happened on the dialplan threads. Tests have shown that "slightly" is in reality "very".
> 
> This patch synchronizes things by making the dialplan applications/functions that manipulate CDRs do so over Stasis. ForkCDR, NoCDR, ResetCDR, CDR, and CDR_PROP now all use Stasis to send their requests over to the CDR engine, and synchronize on the Stasis subscription so that they return their values/control to the dialplan at the appropriate time.
> 
> While going through this, the following changes were also made:
>  * DISA, which can reset the CDR when a user successfully authenticates, now just uses the ResetCDR app to do this. This prevents having to duplicate the same Stasis synchronization logic in that application.
>  * Answer no longer disables CDRs. It actually didn't work anyway - calling DISABLE on the channel's CDR doesn't stop the CDR from getting the Answer time - it just kills all CDRs on that channel, which isn't what the caller would intend.
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/pbx.c 403604 
>   /branches/12/main/cdr.c 403604 
>   /branches/12/include/asterisk/cdr.h 403604 
>   /branches/12/funcs/func_cdr.c 403604 
>   /branches/12/apps/app_forkcdr.c 403604 
>   /branches/12/apps/app_disa.c 403604 
>   /branches/12/apps/app_cdr.c 403604 
>   /branches/12/UPGRADE.txt 403604 
>   /branches/12/CHANGES 403604 
> 
> Diff: https://reviewboard.asterisk.org/r/3057/diff/
> 
> 
> Testing
> -------
> 
> * The CDR tests pass (now deterministicly)
> * The hangup handler tests now pass, as they can get reliable values in the h extension from the CDR engine
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131210/775f6f7c/attachment.html>