[asterisk-dev] [Code Review] 3052: ARI: Allow specifying channel variables during a POST /channels

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3052/#review10346
-----------------------------------------------------------



branches/12/main/http.c
<https://reviewboard.asterisk.org/r/3052/#comment19752>

    size should probably be a size_t here.



branches/12/main/http.c
<https://reviewboard.asterisk.org/r/3052/#comment19751>

    Check for memory allocation failure of type here.
    
    What happens here if v->value is NULL?



branches/12/main/http.c
<https://reviewboard.asterisk.org/r/3052/#comment19754>

    Since nothing else calls get_content_type, you don't really need this function. You could have is_content_type be get_content_type.


- Matt Jordan


On Dec. 5, 2013, 10:42 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3052/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2013, 10:42 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22872
>     https://issues.asterisk.org/jira/browse/ASTERISK-22872
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Added the ability to specify channel variables when creating/originating a channel in ARI.  The variables are sent in the body of the request and should be formatted as a single level JSON object.  For example: {"variable1": "foo", "variable2": "bar"}. No nested objects allowed.
> 
> 
> Diffs
> -----
> 
>   branches/12/rest-api/api-docs/channels.json 403413 
>   branches/12/res/res_ari_channels.c 403413 
>   branches/12/res/ari/resource_channels.c 403413 
>   branches/12/res/ari/resource_channels.h 403413 
>   branches/12/main/http.c 403413 
> 
> Diff: https://reviewboard.asterisk.org/r/3052/diff/
> 
> 
> Testing
> -------
> 
> Some manual testing to make sure variables were being set.  Also wrote a test for the testsuite.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131210/694bad7a/attachment.html>