[asterisk-dev] [Code Review] 3038: Add CHANNEL function support for PJSIP

Matt Jordan reviewboard at asterisk.org
Mon Dec 9 21:51:40 CST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3038/
-----------------------------------------------------------

(Updated Dec. 10, 2013, 3:51 a.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed Mark's findings, except for the documentation ones. If someone has better wording, I'll gladly take it.


Repository: Asterisk


Description
-------

This patch adds CHANNEL function support to chan_pjsip. Since things were getting a bit large, all dialplan functions that were in chan_pjsip have also been moved into their own file (dialplan_functions).

Information that can be retrieved:
 * rtp,type,[media_type] - Get RTP information, including media source/destination addresses, whether or not the media is secure, etc.
 * rtcp,statistic,[media_type] - Get RTCP statistic information
 * endpoint - Get the name of the endpoint associated with this channel. Use PJSIP_ENDPOINT to get more info.
 * pjsip,type - Get signalling related information, including source/destination addresses, URIs in the INVITE request, whether or not the signalling is using a secure transport, etc.

Note that after this patch is committed, we should go back through the CHANNEL function documentation and move all of the channel technology specific information into <info/> blocks, so that the documentation is co-located with the channel drivers themselves.


Diffs (updated)
-----

  /branches/12/res/res_pjsip_t38.c 403470 
  /branches/12/include/asterisk/res_pjsip_session.h 403470 
  /branches/12/funcs/func_channel.c 403470 
  /branches/12/channels/pjsip/include/dialplan_functions.h PRE-CREATION 
  /branches/12/channels/pjsip/include/chan_pjsip.h PRE-CREATION 
  /branches/12/channels/pjsip/dialplan_functions.c PRE-CREATION 
  /branches/12/channels/chan_pjsip.c 403470 
  /branches/12/channels/Makefile 403470 

Diff: https://reviewboard.asterisk.org/r/3038/diff/


Testing
-------

See https://reviewboard.asterisk.org/r/3037


Thanks,

Matt Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131210/aa89acd7/attachment.html>


More information about the asterisk-dev mailing list