[asterisk-dev] [Code Review] 2944: PJSIP messaging: send message to URI.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2944/#review10319
-----------------------------------------------------------



branches/12/res/res_pjsip/config_global.c
<https://reviewboard.asterisk.org/r/2944/#comment19718>

    I don't think this change is warranted.



branches/12/res/res_pjsip/config_global.c
<https://reviewboard.asterisk.org/r/2944/#comment19720>

    This function has a problem similar to some of the problems Josh pointed out on his review.
    
    Since cfg is scoped to this function, once this function returns, cfg->default_outbound_endpoint cannot be assumed safe to use since cfg (and its contents) may get freed.


- Mark Michelson


On Dec. 5, 2013, 8:26 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2944/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2013, 8:26 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Added the ability to send messages to a URI (an associated endpoint is no longer needed). 
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip_messaging.c 403341 
>   branches/12/res/res_pjsip/pjsip_configuration.c 403341 
>   branches/12/res/res_pjsip/include/res_pjsip_private.h 403341 
>   branches/12/res/res_pjsip/config_global.c 403341 
>   branches/12/res/res_pjsip.c 403341 
>   branches/12/include/asterisk/res_pjsip.h 403341 
>   branches/12/configs/pjsip.conf.sample 403341 
> 
> Diff: https://reviewboard.asterisk.org/r/2944/diff/
> 
> 
> Testing
> -------
> 
> Had the PJSIP message module send a SIP message to a specified IP address.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131206/15f9ae7d/attachment.html>