[asterisk-dev] [Code Review] 3022: res_pjsip: Respect outbound proxy in more places

opticron reviewboard at asterisk.org
Thu Dec 5 14:44:10 CST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3022/#review10311
-----------------------------------------------------------



/branches/12/res/res_pjsip/location.c
<https://reviewboard.asterisk.org/r/3022/#comment19706>

    Does this field need to be registered for ast_sip_contact as well?



/branches/12/res/res_pjsip/pjsip_options.c
<https://reviewboard.asterisk.org/r/3022/#comment19702>

    This is missing a word.


- opticron


On Nov. 26, 2013, 2:14 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3022/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2013, 2:14 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22673
>     https://issues.asterisk.org/jira/browse/ASTERISK-22673
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> There are currently cases where the outbound proxy is not available to be set or is not obeyed. The attached change fixes this.
> 
> 1. An outbound proxy can now be specified on the AOR for qualify purposes if wanted.
> 2. An outbound proxy specified on the endpoint is now respected when out-of-dialog requests are created.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip/pjsip_options.c 403158 
>   /branches/12/res/res_pjsip/location.c 403158 
>   /branches/12/res/res_pjsip.c 403158 
>   /branches/12/include/asterisk/res_pjsip.h 403158 
> 
> Diff: https://reviewboard.asterisk.org/r/3022/diff/
> 
> 
> Testing
> -------
> 
> Set the option, confirmed it was used.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131205/88536f57/attachment.html>


More information about the asterisk-dev mailing list