[asterisk-dev] [Code Review] 2944: PJSIP messaging: send message to URI.

[Kevin Harwell]

> On Dec. 5, 2013, 6:56 a.m., Joshua Colp wrote:
> > branches/12/res/res_pjsip_messaging.c, lines 155-156
> > <https://reviewboard.asterisk.org/r/2944/diff/3/?file=48992#file48992line155>
> >
> >     I don't like this. Falling back to the default outbound endpoint if the specified one could not be found could bring about unexpected behavior for the user, and be harder to diagnose. I would prefer that it would be an error situation.
> 
> Kevin Harwell wrote:
>     Where would the default be used then?  I figured by specifying a default outbound endpoint in the config file the user would be aware of the fact that if an endpoint is not found on an outgoing message then the default would be used.
> 
> Joshua Colp wrote:
>     I'd only use it if no endpoint has been specified. I'd rather our behavior be strict (just like the configuration stuff is) instead of implicit behavior which may not be anywhere near what the user wants, and could end up causing problems.

After speaking with Josh on IRC it was decided that there is really no good way to distinguish between an endpoint vs. an ip address.  Especially since an endpoint name could look just like an ip address.  So, going to leave the code as is for this case since we want to check that it is potentially a valid endpoint first.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2944/#review10303
-----------------------------------------------------------


On Dec. 3, 2013, 2:12 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2944/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2013, 2:12 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Added the ability to send messages to a URI (an associated endpoint is no longer needed). 
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip_messaging.c 403341 
>   branches/12/res/res_pjsip/pjsip_configuration.c 403341 
>   branches/12/res/res_pjsip/include/res_pjsip_private.h 403341 
>   branches/12/res/res_pjsip/config_global.c 403341 
>   branches/12/res/res_pjsip.c 403341 
>   branches/12/include/asterisk/res_pjsip.h 403341 
>   branches/12/configs/pjsip.conf.sample 403341 
> 
> Diff: https://reviewboard.asterisk.org/r/2944/diff/
> 
> 
> Testing
> -------
> 
> Had the PJSIP message module send a SIP message to a specified IP address.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131205/732e4ae8/attachment.html>