[asterisk-dev] [Code Review] 3044: Switch PJSIP auth to use a vector

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3044/#review10306
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On Dec. 4, 2013, 10 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3044/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2013, 10 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Since Asterisk 12 introduced vector.h, it's silly to try to roll our own any more. I happened to have used an expandable array construct for authentication in res_pjsip.c, so I figure that I may as well convert it over to use vectors.
> 
> Since this is not adding any critical functionality and is affecting the core of the PJSIP functionality in Asterisk, I elected to make the change against trunk instead of placing the change into 12.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_pjsip_outbound_registration.c 403349 
>   /trunk/res/res_pjsip_outbound_authenticator_digest.c 403349 
>   /trunk/res/res_pjsip_authenticator_digest.c 403349 
>   /trunk/res/res_pjsip/pjsip_distributor.c 403349 
>   /trunk/res/res_pjsip/pjsip_configuration.c 403349 
>   /trunk/res/res_pjsip/config_auth.c 403349 
>   /trunk/res/res_pjsip.c 403350 
>   /trunk/include/asterisk/res_pjsip.h 403349 
> 
> Diff: https://reviewboard.asterisk.org/r/3044/diff/
> 
> 
> Testing
> -------
> 
> Ran inbound/outbound call and outbound registration tests in the testsuite to ensure they still pass.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131205/f3fe4d27/attachment-0001.html>