[asterisk-dev] [Code Review] 2803: Fix Segfault When Syntax Of [applicationmap] Context Line Is Invalid In features.conf

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2803/#review9559
-----------------------------------------------------------

Ship it!


Ship It!

- wdoekes


On Aug. 29, 2013, 4:44 a.m., Michael Young wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2803/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 4:44 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22416
>     https://issues.asterisk.org/jira/browse/ASTERISK-22416
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When processing the lines in the [applicationmap] context, a segfault occurs from attempting to process a line with an invalid syntax (basically missing arguments).
> 
> Example:
> [applicationmap]
> automon=*6
> 
> The fix is to move the checking that the arguments are not empty to before these arguments are accessed.
> 
> Also, checked the "todo" comment and removed it.  Some applications do not require arguments.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/features.c 397876 
> 
> Diff: https://reviewboard.asterisk.org/r/2803/diff/
> 
> 
> Testing
> -------
> 
> Tested by the reporter on the issue.
> 
> 
> Thanks,
> 
> Michael Young
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130829/6185f9c3/attachment-0001.htm>