[asterisk-dev] [Code Review] 2798: Verbose logging discrepancies

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2798/
-----------------------------------------------------------

(Updated Aug. 27, 2013, 9:30 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed issues found.


Bugs: AST-1193
    https://issues.asterisk.org/jira/browse/AST-1193


Repository: Asterisk


Description
-------

Refactored cases where a combination of ast_verbose/options_verbose were present.  Also in general tried to eliminate, in as many places as possible, where the options_verbose global variable was being used.  Refactored the way local and remote consoles handle verbose message logging in an attempt to solve the various discrepancies that sometimes would show between the two.


Diffs (updated)
-----

  branches/11/main/logger.c 397483 
  branches/11/main/features.c 397483 
  branches/11/main/asterisk.c 397483 
  branches/11/channels/chan_misdn.c 397483 
  branches/11/apps/app_verbose.c 397483 
  branches/11/apps/app_dumpchan.c 397483 

Diff: https://reviewboard.asterisk.org/r/2798/diff/


Testing
-------

Tested several logging scenarios with various combinations of levels, messages, and consoles.  Also made sure the app_verbose and dumpchan were still working as expected after the changes.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130827/619e5fa8/attachment.htm>