[asterisk-dev] [Code Review] 2780: Fix the dial_LS_options test

Matt Jordan reviewboard at asterisk.org
Tue Aug 27 09:07:00 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2780/#review9523
-----------------------------------------------------------

Ship it!



asterisk/trunk/tests/bridge/dial_LS_options/Tester.py
<https://reviewboard.asterisk.org/r/2780/#comment18641>

    I think we need to increase the tolerance here a tad.
    
    On at least one build agent, this test failed because the timeout came back at 10.7 seconds. It seems a little goofy to fail it for that, particularly when that only occurred because the 64-bit build agent is SLLOOOOWWWW.


- Matt Jordan


On Aug. 21, 2013, 7:05 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2780/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2013, 7:05 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22326
>     https://issues.asterisk.org/jira/browse/ASTERISK-22326
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This introduces code to the dial_LS_options test to detect when Asterisk versions later than 11 are used and to expect the appropriate events and number of events.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/bridge/dial_LS_options/Tester.py 4056 
> 
> Diff: https://reviewboard.asterisk.org/r/2780/diff/
> 
> 
> Testing
> -------
> 
> The test now runs correctly and generates the proper output.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130827/b1bf6601/attachment.htm>


More information about the asterisk-dev mailing list