[asterisk-dev] [Code Review] 2779: Testsuite: Update callparking_retrieval test

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2779/
-----------------------------------------------------------

(Updated Aug. 26, 2013, 7:27 p.m.)


Review request for Asterisk Developers, kmoore and Matt Jordan.


Changes
-------

Kinsey's feedback.


Bugs: ASTERISK-22328
    https://issues.asterisk.org/jira/browse/ASTERISK-22328


Repository: testsuite


Description
-------

This test had been skipped due to failures for some time and also wouldn't work with 12. It turned out to be written in BASH, so I rewrote the test in Python. The functionality is pretty much the same though, just substituting originating through asterisk command line execution to using AMI to originate and also adding extra verification that the parking is taking place with the expected parameters regarding who is being parked and who is retrieving calls as well as having a certain flow of AMI events.


Diffs (updated)
-----

  /asterisk/trunk/tests/callparking_retrieval/userA/iax.conf 4056 
  /asterisk/trunk/tests/callparking_retrieval/userA/extensions.conf 4056 
  /asterisk/trunk/tests/callparking_retrieval/test-config.yaml 4056 
  /asterisk/trunk/tests/callparking_retrieval/run-test 4056 
  /asterisk/trunk/tests/callparking_retrieval/configs/ast3/res_parking.conf PRE-CREATION 
  /asterisk/trunk/tests/callparking_retrieval/configs/ast3/iax.conf PRE-CREATION 
  /asterisk/trunk/tests/callparking_retrieval/configs/ast3/features.conf PRE-CREATION 
  /asterisk/trunk/tests/callparking_retrieval/configs/ast3/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/callparking_retrieval/configs/ast2/iax.conf PRE-CREATION 
  /asterisk/trunk/tests/callparking_retrieval/configs/ast2/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/callparking_retrieval/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/callparking_retrieval/configs/ast1/features.conf PRE-CREATION 
  /asterisk/trunk/tests/callparking_retrieval/configs/ast1/iax.conf PRE-CREATION 
  /asterisk/trunk/tests/callparking_retrieval/configs/ast1/res_parking.conf PRE-CREATION 
  /asterisk/trunk/tests/callparking_retrieval/userC/iax.conf 4056 
  /asterisk/trunk/tests/callparking_retrieval/userC/features.conf 4056 
  /asterisk/trunk/tests/callparking_retrieval/userB/extensions.conf 4056 
  /asterisk/trunk/tests/callparking_retrieval/userB/iax.conf 4056 
  /asterisk/trunk/tests/callparking_retrieval/userC/extensions.conf 4056 

Diff: https://reviewboard.asterisk.org/r/2779/diff/


Testing
-------

Ran the test against 1.8 and 12 to check that they pass. Checked failures by supplying known bad expectations.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130826/e0678861/attachment.htm>