[asterisk-dev] [Code Review] 2770: TestSuite: ARI Bridge Tests

opticron reviewboard at asterisk.org
Fri Aug 23 14:19:01 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2770/#review9510
-----------------------------------------------------------



/asterisk/team/dlee/matts-ari-patch/lib/python/asterisk/ari.py
<https://reviewboard.asterisk.org/r/2770/#comment18609>

    I like it!



/asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/hangup/bridge_hangup.py
<https://reviewboard.asterisk.org/r/2770/#comment18611>

    This doesn't appear to be used and would throw and exception if it was.



/asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/unhappy/bridge_unhappy.py
<https://reviewboard.asterisk.org/r/2770/#comment18612>

    Debugging that got left in?


- opticron


On Aug. 19, 2013, 2:54 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2770/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2013, 2:54 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22036
>     https://issues.asterisk.org/jira/browse/ASTERISK-22036
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> TestSuite tests that test the expected behavior for adding/removing
> channel to/from bridges using ARI.
> 
> 
> Diffs
> -----
> 
>   /asterisk/team/dlee/matts-ari-patch/lib/python/asterisk/TestCase.py 4054 
>   /asterisk/team/dlee/matts-ari-patch/lib/python/asterisk/TestConfig.py 4054 
>   /asterisk/team/dlee/matts-ari-patch/lib/python/asterisk/ari.py 4054 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/hangup/bridge_hangup.py PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/hangup/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/hangup/test-config.yaml PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/happy/bridge_happy.py PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/happy/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/happy/test-config.yaml PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/move/bridge_move.py PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/move/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/move/test-config.yaml PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/tests.yaml PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/unhappy/bridge_unhappy.py PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/unhappy/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/bridges/unhappy/test-config.yaml PRE-CREATION 
>   /asterisk/team/dlee/matts-ari-patch/tests/rest_api/tests.yaml 4054 
> 
> Diff: https://reviewboard.asterisk.org/r/2770/diff/
> 
> 
> Testing
> -------
> 
> Tests pass.
> 
> https://reviewboard.asterisk.org/r/2769/
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130823/4ce97659/attachment-0001.htm>


More information about the asterisk-dev mailing list