[asterisk-dev] [Code Review] 2789: testsuite: Fix fastagi/control-stream-file for Asterisk 12

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2789/#review9490
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On Aug. 22, 2013, 3:38 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2789/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2013, 3:38 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Bugs: ASTERISK-22322
>     https://issues.asterisk.org/jira/browse/ASTERISK-22322
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Asterisk 12 changes the response of AGI 'control stream file' to include
> the endpos of where the playback stopped.
> 
> StarPy [has a patch][1] to take this into account. This patch corrects
> the corresponding test in the TestSuite.
> 
> In addition to fixing the test:
>  * print statements were replaced with logging
>  * clarified the logic for handling the response to controlStreamFile().
> 
>  [1]: https://github.com/asterisk/starpy/pull/23
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/fastagi/control-stream-file/run-test 4062 
> 
> Diff: https://reviewboard.asterisk.org/r/2789/diff/
> 
> 
> Testing
> -------
> 
> Test passes for Asterisk 1.8 and 12.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130822/2a851c01/attachment-0001.htm>