[asterisk-dev] [Code Review] 2788: Make CEL behavior conform to the current documentation

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2788/#review9476
-----------------------------------------------------------

Ship it!



/trunk/tests/test_cel.c
<https://reviewboard.asterisk.org/r/2788/#comment18555>

    If you haven't already, make an issue to fix this.


- Matt Jordan


On Aug. 22, 2013, 1:07 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2788/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2013, 1:07 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21567
>     https://issues.asterisk.org/jira/browse/ASTERISK-21567
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This modifies the behavior of the CEL engine to conform to documented behavior for Asterisk 12 as defined on the wiki https://wiki.asterisk.org/wiki/display/AST/Asterisk+12+CEL+Specification
> 
> The primary changes deal with removal of the peer field from function calls since it is no longer directly relevant to the bridging system and removal of the layer of CDR-like business logic that was providing a partial emulation of Asterisk 11 CEL functionality. With this change, there is no longer a distinction between "bridges" and "conferences" and all participation changes are denoted with bridge enter and bridge exit messages.
> 
> This updates the CEL unit tests to handle these changes and simplifies some of the macros used in the process.
> 
> This also fixes a segfault when attempting to ref a configuration that failed to load.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/cel.h 397417 
>   /trunk/main/cel.c 397417 
>   /trunk/tests/test_cel.c 397417 
> 
> Diff: https://reviewboard.asterisk.org/r/2788/diff/
> 
> 
> Testing
> -------
> 
> The unit tests pass and produce the expected output.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130822/c38d5c89/attachment.htm>