[asterisk-dev] [Code Review] 2773: UDPTL: Allow UDPTL to use default configurations when no udptl.conf is present

[svnbot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2773/
-----------------------------------------------------------

(Updated Aug. 21, 2013, 6:02 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers, kmoore, Matt Jordan, and Mark Michelson.


Changes
-------

Committed in revision 397365


Bugs: ASTERISK-22349
    https://issues.asterisk.org/jira/browse/ASTERISK-22349


Repository: Asterisk


Description
-------

If UDPTL failed to load properly due to lack of a configuration file, Asterisk would log a failure to load the configuration, but would continue to function normally until UDPTL configuration was needed by a consumer at which point it would fail to find the global UDPTL configuration and fail, often without displaying a good reason for the failure.


Diffs
-----

  /branches/11/main/udptl.c 397192 

Diff: https://reviewboard.asterisk.org/r/2773/diff/


Testing
-------

Compared the differences before and after the patch with the following:

1. No udptl.conf present in /etc/asterisk
2. load Asterisk
3. issue comand udptl show config

prior to patch:

*CLI> udptl show config
Command 'udptl show config ' failed.


after the patch:

*CLI> udptl show config 
UDPTL Global options
--------------------
udptlstart:      4000
udptlend:        4999
udptlfecentries: 0
udptlfecspan:    0
use_even_ports:  No
udptlchecksums: Yes


Seems pretty open and shut to me.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130821/c36fec7d/attachment.htm>