[asterisk-dev] [Code Review] 2745: Improve sounds indexer CLI commands

David Lee reviewboard at asterisk.org
Thu Aug 15 16:48:12 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2745/#review9415
-----------------------------------------------------------

Ship it!


No objections!

- David Lee


On Aug. 7, 2013, 7:20 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2745/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2013, 7:20 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22141
>     https://issues.asterisk.org/jira/browse/ASTERISK-22141
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This reworks the CLI commands used to access sounds information from "sounds show[ soundid]" to "core show sounds" and "core show sound <soundid>". This also reworks the "sounds reload" CLI command to fall under normal module reloading ("module reload sounds").
> 
> 
> Diffs
> -----
> 
>   /trunk/main/loader.c 396354 
>   /trunk/main/sounds_index.c 396354 
> 
> Diff: https://reviewboard.asterisk.org/r/2745/diff/
> 
> 
> Testing
> -------
> 
> Verified that all commands functioned properly.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130815/3b33e4eb/attachment.htm>


More information about the asterisk-dev mailing list