[asterisk-dev] [Code Review] 2732: Refactor CEL to avoid using the event system as a distribution mechanism

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2732/#review9372
-----------------------------------------------------------



team/kmoore/event_system_strip/main/cel.c
<https://reviewboard.asterisk.org/r/2732/#comment18430>

    Picky: Put a space between variable declarations and code



team/kmoore/event_system_strip/res/res_pjsip_notify.c
<https://reviewboard.asterisk.org/r/2732/#comment18431>

    I'm assuming the PJSIP changes in this code review aren't relevant?
    


- Matt Jordan


On Aug. 2, 2013, 1:44 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2732/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2013, 1:44 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This removes usage of the event system for CEL backend data distribution and strips unused pieces out of the event system.
> 
> This build on the work in https://reviewboard.asterisk.org/r/2703/
> 
> 
> Diffs
> -----
> 
>   team/kmoore/event_system_strip/cel/cel_custom.c 396101 
>   team/kmoore/event_system_strip/cel/cel_manager.c 396101 
>   team/kmoore/event_system_strip/cel/cel_odbc.c 396101 
>   team/kmoore/event_system_strip/cel/cel_pgsql.c 396101 
>   team/kmoore/event_system_strip/cel/cel_radius.c 396101 
>   team/kmoore/event_system_strip/cel/cel_sqlite3_custom.c 396101 
>   team/kmoore/event_system_strip/cel/cel_tds.c 396101 
>   team/kmoore/event_system_strip/include/asterisk/_private.h 396101 
>   team/kmoore/event_system_strip/include/asterisk/cel.h 396101 
>   team/kmoore/event_system_strip/include/asterisk/event.h 396101 
>   team/kmoore/event_system_strip/include/asterisk/event_defs.h 396101 
>   team/kmoore/event_system_strip/main/asterisk.c 396101 
>   team/kmoore/event_system_strip/main/cel.c 396101 
>   team/kmoore/event_system_strip/main/event.c 396101 
>   team/kmoore/event_system_strip/res/res_pjsip.c 396101 
>   team/kmoore/event_system_strip/res/res_pjsip/include/res_pjsip_private.h 396101 
>   team/kmoore/event_system_strip/res/res_pjsip/pjsip_options.c 396101 
>   team/kmoore/event_system_strip/res/res_pjsip_notify.c 396101 
>   team/kmoore/event_system_strip/res/res_pjsip_outbound_registration.c 396101 
>   team/kmoore/event_system_strip/tests/test_cel.c 396101 
>   team/kmoore/event_system_strip/tests/test_event.c 396101 
> 
> Diff: https://reviewboard.asterisk.org/r/2732/diff/
> 
> 
> Testing
> -------
> 
> Unit tests still pass for both CEL and what's left of the event system.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130809/37c064ca/attachment-0001.htm>