[asterisk-dev] [Code Review] 2727: Improve disk writes for wav49

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2727/#review9359
-----------------------------------------------------------

Ship it!


Ship It!

- opticron


On July 31, 2013, 5:43 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2727/
> -----------------------------------------------------------
> 
> (Updated July 31, 2013, 5:43 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-19595
>     https://issues.asterisk.org/jira/browse/ASTERISK-19595
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> {quote}
> Writing to a wav49 looks a lot like this:
>  * Write GSM frame to end of file
>  * Seek to end of file
>  * Seek to header
>  * Update file size
>  * Seek to end of file
>  * Repeat
> 
> This pattern negates any attempt to use the stdio buffering setup in ast_writefile(). It also results in many small writes that require a seek going to the disk each second which translates to terrible disk performance when there are multiple wav49 files being written at the same time.
> {quote}
> 
> 
> Diffs
> -----
> 
>   /trunk/formats/format_wav_gsm.c 395904 
> 
> Diff: https://reviewboard.asterisk.org/r/2727/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130808/d653825b/attachment.htm>