[asterisk-dev] [Code Review] 2721: bridge_channels: Add support for the lonely flag

jrose reviewboard at asterisk.org
Tue Aug 6 13:05:09 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2721/
-----------------------------------------------------------

(Updated Aug. 6, 2013, 6:05 p.m.)


Review request for Asterisk Developers, David Lee, Matt Jordan, and rmudgett.


Changes
-------

Address the reviews. Update the patch to a more recent trunk.


Bugs: ASTERISK-22117
    https://issues.asterisk.org/jira/browse/ASTERISK-22117


Repository: Asterisk


Description
-------

Channels with the lonely flag are supposed to leave a bridge if all of the channels in that bridge are also lonely at the time of a channel dissolving.
I also added this flag to ARI play and record on bridge channels.


Diffs (updated)
-----

  /trunk/include/asterisk/bridge.h 396342 
  /trunk/include/asterisk/core_unreal.h 396342 
  /trunk/main/bridge_channel.c 396342 
  /trunk/main/core_unreal.c 396342 
  /trunk/res/ari/resource_bridges.c 396342 

Diff: https://reviewboard.asterisk.org/r/2721/diff/


Testing
-------

Tested what happens to channels when a non-lonely channel leaves with and without the presence of non-lonely channels.
If only lonely channels were left, they hung up. This did produce an ARI playback error since the channel playback was interrupted.
If non-lonely channels were left, nothing would happen as anticipated.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130806/afb3cdda/attachment.htm>


More information about the asterisk-dev mailing list