[asterisk-dev] [Code Review] 2738: Stasis - tweak caching topics to fix CEL tests

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2738/#review9328
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On Aug. 2, 2013, 10:56 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2738/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2013, 10:56 p.m.)
> 
> 
> Review request for Asterisk Developers and kmoore.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The Stasis changes in r395954 had an unanticipated side effect: messages
> published directly to an _all topic does not get forwarded to the
> corresponding caching topic.
> 
> This patch fixes that by changing how caching topics forward messages,
> and how the caching pattern forwards are setup.
> 
> For the caching pattern, the all_topic is forwarded to the
> all_topic_cached. This forwards messages published directly to the
> all_topic to all_topic_cached.
> 
> In order to avoid duplicate messages on all_topic_cached, caching topics
> were changed to no longer forward uncached messages. Subscribers to an
> individual caching topic should only expect to receive cache updates,
> and subscription change messages. Since individual caching topics are
> new, this shouldn't be a problem.
> 
> There are a few minor changes to the pre-cache split behavior.
> 
>  * For topics changed to use the caching pattern, the all_topic_cached
>    will forward snapshots in addition to cache updates. Since
>    subscribers by design ignore unexpected messages, this should be
>    fine.
> 
>  * Caching topics that don't use the caching pattern no longer forward
>    non-cache updates. This makes no difference for the current caching
>    topics.
> 
>    * mwi_topic_cached, channel_by_name_topic and
>      presence_state_topic_cached have no subscribers
> 
>    * device_state_topic_cached's only subscriber only processes cache
>      udpates
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/stasis.h 396153 
>   /trunk/main/stasis_cache.c 396153 
>   /trunk/main/stasis_cache_pattern.c 396153 
>   /trunk/tests/test_stasis.c 396153 
> 
> Diff: https://reviewboard.asterisk.org/r/2738/diff/
> 
> 
> Testing
> -------
> 
> Ran unit tests several times.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130805/88dee1fd/attachment-0001.htm>