[asterisk-dev] [Code Review] 2704: Expose res_sip threadpool options

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2704/#review9307
-----------------------------------------------------------



trunk/res/res_pjsip/config_system.c
<https://reviewboard.asterisk.org/r/2704/#comment18353>

    You should be able to omit the default values that are specified by ast_sorcery_object_field_register() calls below. At least that makes it one less place where you have to go change the default value if we ever want to change the default.



trunk/res/res_pjsip/config_system.c
<https://reviewboard.asterisk.org/r/2704/#comment18350>

    You may need to aco_set_defaults(), in case the [system] section is missing from the config.


- David Lee


On Aug. 1, 2013, 10:17 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2704/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 10:17 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22143
>     https://issues.asterisk.org/jira/browse/ASTERISK-22143
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Expose initial size, maximum size, and idle timeout as configurable parameters for the res_sip thread pool.
> 
> 
> Diffs
> -----
> 
>   trunk/res/res_pjsip.c 395969 
>   trunk/res/res_pjsip/config_system.c 395969 
>   trunk/res/res_pjsip/include/res_pjsip_private.h 395969 
> 
> Diff: https://reviewboard.asterisk.org/r/2704/diff/
> 
> 
> Testing
> -------
> 
> Made sure that Asterisk came up and calls still worked.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130801/2d7049f9/attachment-0001.htm>