[asterisk-dev] [Code Review] 2719: Move ast_str_container_alloc and friends to a better location

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2719/#review9291
-----------------------------------------------------------

Ship it!



trunk/utils/Makefile
<https://reviewboard.asterisk.org/r/2719/#comment18298>

    astobj2.c was already there.


Minor nit; otherwise looks fine to me.

- David Lee


On July 31, 2013, 9:23 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2719/
> -----------------------------------------------------------
> 
> (Updated July 31, 2013, 9:23 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22041
>     https://issues.asterisk.org/jira/browse/ASTERISK-22041
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This moves ast_str_container_alloc, ast_str_container_add, ast_str_container_remove, and related private functions into strings.c/h since they really don't belong in astobj2.c/h.
> 
> 
> Diffs
> -----
> 
>   trunk/utils/Makefile 395852 
>   trunk/utils/refcounter.c 395852 
>   trunk/main/strings.c 395852 
>   trunk/include/asterisk/strings.h 395852 
>   trunk/main/astobj2.c 395852 
>   trunk/include/asterisk/astobj2.h 395852 
> 
> Diff: https://reviewboard.asterisk.org/r/2719/diff/
> 
> 
> Testing
> -------
> 
> It compiles (even utils).
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130801/8d06a847/attachment.htm>