[asterisk-dev] [Code Review] 2695: Add CLI/AMI commands to force chan_pjsip actions

Joshua Colp reviewboard at asterisk.org
Thu Aug 1 09:49:36 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2695/#review9278
-----------------------------------------------------------

Ship it!



/trunk/res/res_pjsip_notify.c
<https://reviewboard.asterisk.org/r/2695/#comment18278>

    an endpoint name



/trunk/res/res_pjsip_outbound_registration.c
<https://reviewboard.asterisk.org/r/2695/#comment18279>

    I'm being picky and this isn't a blocker but "The outbound registration to unregister"


- Joshua Colp


On Aug. 1, 2013, 2:39 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2695/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 2:39 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21939
>     https://issues.asterisk.org/jira/browse/ASTERISK-21939
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds CLI and AMI commands for unregistration of chan_pjsip outbound registrations, adds an AMI command for forcing the qualification of a chan_pjsip endpoint, and documents and reworks the chan_pjsip NOTIFY commands.
> 
> In the process of implementing this, two refcounting bugs in the outbound registration code were also fixed.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_pjsip.c 395969 
>   /trunk/res/res_pjsip/include/res_pjsip_private.h 395969 
>   /trunk/res/res_pjsip/pjsip_options.c 395969 
>   /trunk/res/res_pjsip_notify.c 395969 
>   /trunk/res/res_pjsip_outbound_registration.c 395969 
> 
> Diff: https://reviewboard.asterisk.org/r/2695/diff/
> 
> 
> Testing
> -------
> 
> Tested all new commands for chan_pjsip against a remote chan_sip.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130801/0a675956/attachment.htm>


More information about the asterisk-dev mailing list