[asterisk-dev] Post-review dead?

[Tzafrir Cohen]

On Mon, Apr 29, 2013 at 08:12:15PM +0200, Olle E. Johansson wrote:
> 
> 29 apr 2013 kl. 16:40 skrev Mark Michelson <mmichelson at digium.com>:
> 
> > On 04/29/2013 04:57 AM, Olle E. Johansson wrote:
> >> $ LANG=C ../repotools/post-review
> >> Unable to access https://reviewboard.asterisk.org/api/json/reviewrequests/new/. The host path may be invalid
> >> HTTP Error 404: Not Found
> >> 
> >> Using repotools rev 851
> >> 
> >> /O
> > 
> > You should probably use the post-review script included in the RBTools python package. See the "Posting Code to Reviewboard" section on this page for information: https://wiki.asterisk.org/wiki/display/AST/Reviewboard+Usage
> 
> Have installed RBTools.
> 
> $ post-review --server=https://reviewboard.asterisk.org
> There don't seem to be any diffs!

It should get the server name from an SVN property in the repository.

Though lately I have had many issues with it.

Git users: there's a wrapper script to convert a git diff to something
submittable to the reviewboard (manually or through post-review) in the
asterisk-tools repo.

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen at xorcom.com
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir