[asterisk-dev] [Code Review] 2478: Support multiple Require: and Supported: headers in the same request

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2478/#review8394
-----------------------------------------------------------

Ship it!


nit picking, but I think I'm right.


branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2478/#comment16162>

    do we need to init variable, as __get_header is always run.



branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2478/#comment16157>

    I'd us the 'start' declared for the function. Still will need start=0;
    
    further down need to reinit start.
    



branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2478/#comment16160>

    don't need to initialise variable, as __get_header is always run. 



branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2478/#comment16158>

    after do {
    
    start = 0; 


- Alec Davis


On April 29, 2013, 12:38 p.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2478/
> -----------------------------------------------------------
> 
> (Updated April 29, 2013, 12:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21721
>     https://issues.asterisk.org/jira/browse/ASTERISK-21721
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> We have servers sending multiple Supported: and Require: options in separate headers in the same message. This patch fixes that support so that we parse more than the first header found.
> 
> 
> Diffs
> -----
> 
>   branches/1.8/channels/chan_sip.c 386791 
>   branches/1.8/channels/sip/reqresp_parser.c 386791 
> 
> Diff: https://reviewboard.asterisk.org/r/2478/diff/
> 
> 
> Testing
> -------
> 
> Tested with the server that caused the issue. Problem solved and we did reach interoperability!
> 
> 
> Thanks,
> 
> Olle E Johansson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130429/3e9afbdb/attachment-0001.htm>