[asterisk-dev] [Code Review] 2479: Use the correct lower bound for saturated arithmetic

Mark Michelson reviewboard at asterisk.org
Mon Apr 29 09:56:07 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2479/#review8391
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On April 29, 2013, 2:06 p.m., Sean Bright wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2479/
> -----------------------------------------------------------
> 
> (Updated April 29, 2013, 2:06 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The current ast_slinear_saturated_* functions use a lower bound of -32767, where they should be using -32768.  I'm only posting the review in case I am missing something obvious.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/include/asterisk/utils.h 386841 
> 
> Diff: https://reviewboard.asterisk.org/r/2479/diff/
> 
> 
> Testing
> -------
> 
> Compilation and ran a few calls through ConfBridge
> 
> 
> Thanks,
> 
> Sean Bright
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130429/79465315/attachment-0001.htm>


More information about the asterisk-dev mailing list